Update to uhtml5 and drop cjs Support#26
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Updated dependencies that were outdated. Major version upgrades include rollup and ascjs. - Updated uhtml to v4.4.7. - Added DocumentFragment to globalThis for tests.
Upgrade to uhtml 4
- Looks to update uce to use uhtml5. - Uhtml5 looks to drop cjs support. ESM is the thing nowadays, so this looks to align with that - Adds unit test for formAssociated static to achieve 100% coverage - Moves coveralls to coveralls-next re: nickmerwin/node-coveralls#331
- Exports new signal utilities, etc from uhtml 5 from uce
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Andrea 👋,
About 2 years ago, I submitted a PR to upgrade to uhtml4. At the time you suggested we hold off because uhtml/hydro was in progress.
Since then uhtml5 has released with some cool new features, and it seems like the direction has changed, so I figured now might be the time to see about bringing it in here.
This PR attempts to do the following:
Coverage and build size after changes:
It looks like uhtml5 drops cjs support, which makes sense since that is the direction everything is going/has gone. I didn't see that mentioned explicitly in the uhtml5 docs, but it seems like since v4 the cjs build has been dropped, so I apologize in advance if I misread the intention there.
Please let me know if there's any improvements I can make here, or if this isn't the direction you had in mind.
Thanks!