Validate mpy load#1972
Merged
Validate mpy load #1972
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Rollback HID to save string space and remove board mapping for default buses that don't exist.
dhalbert approved these changes Jun 27, 2019
| } | ||
| } | ||
| raise_corrupt_mpy(); | ||
| return MP_OBJ_FROM_PTR(&mp_const_none_obj); |
Collaborator
There was a problem hiding this comment.
The return value is a size_t, not an mp_obj_t. If the compiler is forcing you to return something, even though it will never get executed, just return 0, I'd say.
Collaborator
There was a problem hiding this comment.
Never mind, confused by diff listing with missing lines.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should help prevent hard crashes when an mpy file is corrupt.