Day 3, bro!#1
Closed
Day 3, bro! #1
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Owner
afaur commented Dec 19, 2016
Did you even test this? This doesn't work. |
Author
bayleedev commented Dec 19, 2016
Merge conflict. Apparently the thing I cloned and the thing you had were different. My See bdbe853 |
Owner
afaur commented Dec 19, 2016
Still not correct... Did you not notice how when you first open the page your image is super blurry and the slider for blur is all the way down? |
Owner
afaur commented Dec 19, 2016
Also, I completed this already in a different way. Going to close this PR. |
Owner
Why do you set an initial value for the css properties in the style section? I think the point was that the controls should be bound to the css alterations directly. |
Author
bayleedev commented Dec 19, 2016
The default values changed, who cares? |
Author
bayleedev commented Dec 19, 2016
I had merge conflicts because you have an out of date master. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.