Skip to content

Add free-threaded python to CI including multithreading test#358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ddelange wants to merge 5 commits into
base:master
Choose a base branch
from
Open

Add free-threaded python to CI including multithreading test #358

ddelange wants to merge 5 commits into from
+28 −1

Conversation

@ddelange
Copy link
Contributor

@ddelangeddelange commented Oct 14, 2025•
edited
Loading

Supersedes #357, follow-up on 8a35137

ddelange
ddelange commented Oct 14, 2025
View reviewed changes
@ddelangeddelange changed the title Free threadingMake top level libmagic functions thread-safe, add free-threaded python to CIOct 14, 2025
@ddelangeddelangeforce-pushed the free-threading branch 2 times, most recently from 74dfc08 to 79b6d26CompareOctober 14, 2025 11:38
cclauss
cclauss reviewed Oct 14, 2025
View reviewed changes
cclauss
cclauss reviewed Oct 14, 2025
View reviewed changes
ddelange
ddelange commented Oct 14, 2025
View reviewed changes
cclauss
cclauss approved these changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@cclausscclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks.

@ddelangeddelange changed the title Make top level libmagic functions thread-safe, add free-threaded python to CIAdd free-threaded python to CI including multithreading testOct 17, 2025
@ddelange
Copy link
ContributorAuthor

ddelange commented Oct 17, 2025

simplified the diff here because the global libmagic functions are in fact thread-safe as long as you call them with a different cookie. so having the lock inside the Magic class is in fact correct.

@cclauss
Copy link
Contributor

cclauss commented Oct 17, 2025

Awesome!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cclausscclausscclauss approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ddelange@cclauss