Skip to content

Conversation

@berquist
Copy link
Member

Unsure if I should also take this opportunity to C++-ify things (things should be passed by const reference).

@berquistberquist added Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.) Hacktoberfest The label for all Hacktoberfest related things! labels Oct 11, 2019
@leios
Copy link
Member

Feel free to update this to be more C++y, if you like! Also: don't forget to update the text for the new line numbers

@berquist
Copy link
MemberAuthor

Ok, this is ready for re-review.

Copy link
Member

@leiosleios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change, the travis build is failing for a known reason, #653

@leiosleios merged commit 4c73370 into algorithm-archivists:masterNov 10, 2019
@berquistberquist deleted the graham-scan-cpp branch May 24, 2020 17:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HacktoberfestThe label for all Hacktoberfest related things!Implementation EditThis provides an edit to an algorithm implementation. (Code and maybe md files are edited.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@berquist@leios