Skip to content

Conversation

@Vexatos
Copy link
Contributor

Replaced division and flooring with actual floor division. Also prettified formatting and print statements.

@VexatosVexatosforce-pushed the computus-julia-fix branch from 9c3ecc8 to 1ae77d5CompareApril 24, 2020 13:38
@Vexatos
Copy link
ContributorAuthor

Vexatos commented Apr 24, 2020

It may be considered whether to use % and ÷ instead of mod and fld. In this case, they would be functionally identical, but use infix notation instead, which might or might not be easier to read.

Copy link
Member

@jiegilletjiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. The inconsistent spacing was bugging me :)
I would keep fld and mod over their symbol version, more readable.

@leios
Copy link
Member

Yup, thanks for cleaning this up!

@leiosleios merged commit ae22d4c into algorithm-archivists:masterApr 24, 2020
@berquistberquist added the Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.) label May 24, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Implementation EditThis provides an edit to an algorithm implementation. (Code and maybe md files are edited.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Vexatos@leios@jiegillet@berquist