Skip to content

Show other results from GOV.UK in a scoped search#784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evilstreak merged 8 commits into from
Apr 13, 2015
Merged

Show other results from GOV.UK in a scoped search #784

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6c3d93f
`count` should be a string / trailing comma
Mar 30, 2015
dc90a5e
Unpack metaprogramming
Apr 7, 2015
f9c24d7
fix typo
Apr 7, 2015
318731b
Extract result to separate view
Mar 31, 2015
962a37c
Add request for extra results
Mar 30, 2015
01e73e1
Extract scoped search to separate presenter
Apr 7, 2015
46b581a
Expose unscoped results to mustache view
Apr 7, 2015
a933fc9
Styles for unscoped results pullout
Apr 7, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
NextNext commit
count should be a string / trailing comma 
`count` should be a string not an integer, though there should only ever be 1 result when searching by link anyway. Add a trailing comma for cleaner diffs(tm).
  • Loading branch information
Alice Bartlett committed Apr 9, 2015
commit 6c3d93f52a51fcffad75234530d510f37c4b2b66
4 changes: 2 additions & 2 deletions lib/search_api.rb
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@ def scope_info
{
scope:{
title: scope_object.title,
}
},
}
else
{}
Expand All@@ -45,7 +45,7 @@ def rummager_params
end

def scope_object
@scope_object ||= api.unified_search(filter_link: scope_object_link, count: 1, fields: %w{title}).results.first
@scope_object ||= api.unified_search(filter_link: scope_object_link, count: "1", fields: %w{title}).results.first
end

def is_scoped?
Expand Down
2 changes: 1 addition & 1 deletion test/unit/search_api_test.rb
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@ class SearchAPITest < ActiveSupport::TestCase
@search_params.expects(:filter).with('manual').returns([@manual_link])
@manual_search_response = stub(results: [stub(title: @manual_title)])

@rummager_api.expects(:unified_search).with(filter_link: @manual_link, count: 1, fields: %w{title}).returns(@manual_search_response)
@rummager_api.expects(:unified_search).with(filter_link: @manual_link, count: "1", fields: %w{title}).returns(@manual_search_response)
end

should "returns search results from rummager" do
Expand Down