feat(command): ng test command runs karma

[Brocco]

Overrode the ember-cli test command to initialize the karma server
Then start the karma server based upon the karma.conf.js config file

closes#70

[cironunes]

What about having this.server.start() inside this function?

varpromise=newPromise(function(){returnthis.server.start();});

[Brocco]

That works update coming soon.

Been doing a whole bunch of TypeScript recently, so it didn't occur to me that lexical scoping via fat arrow wasn't in play in your snippet, so it had to be tweaked to:

varserver=this.server;returnnewPromise(function(){returnserver.start();});// orvarself=this;// orreturnnewPromise(function(){returnthis.server.start();}.bind(this));

I've opted to go w/ .bind

[IgorMinar]

use require.resolve instead

[Brocco]

@IgorMinar I'm not familiar w/ require.resolve are you suggesting that I use do this:

this.karma = this.karma || require(require.resolve(cwd + '/node_modules/karma/lib/index'));

[IgorMinar]

no that's not right. the problem is that we can't be hardcoding paths because it will cause issues on windows.

why can't we just say require('karma')? wouldn't that resolve correctly?

cwd points to the application dir and this file should be executed from cwd + '/node_modules/angular-cli/addon/ng2/commands/test.jsno? If that's the case thenrequire('karma')` should just work...

[IgorMinar]

shouldn't we trigger ng build when running ng test?

otherwise this looks good, I think.

@cironunes can you take a look as well?

@cironunes, @Brocco can you open another issue to integrate the build pipeline with karma so that we automatically rebuild the project when src changes, which then updates dist. we should then tell karma to rerun the tests. angular/angular repo has this setup. the implementation is a bit messy but it's a good start.

[cironunes]

@Brocco, nice one. As Igor said, please just make sure to run ng build before starting karma.

@IgorMinar, created the issue #87

[Brocco]

ng test will now execute a build and kick off karma

[IgorMinar]

do we need these two skip flags? I think they are needed only for init and new

[Brocco]

I went back and checked ember's implementation and couldn't find a test spec for the test command. I think it is because we would need to run an npm install... otherwise requiring karma will fail

[IgorMinar]

but ng init is executed above with these flags. I don't thing we need the flags here. they don't do anything. try removing.

[cironunes]

Protractor integration is getting done: #94.

Will we integrate it on ng test in this PR or do you want me to create a separate issue so we can discuss?

We'll probably need some flags as Igor were saying ng test --all(default)/unit/e2e

[IgorMinar]

I suggest we commit this first and then add protractor in a follow up PR

wrt ng test running protractor tests - I dunno, historically we've always treated e2e tests differently because they are slow and people rarely run them locally (only if CI is broken). So I think that we should make it easy to run e2e tests locally, but don't run them by default.

I'm open to be convinced otherwise. But again, we can discuss that in a follow up PR

[IgorMinar]

@Brocco are you blocked on anything? If not, can you resolve the comments above please so that we can merge this in?

[Brocco]

@IgorMinar I'm still not sure how to go about testing the test command (npm test from the cli project)

I updated this branch/PR to exclude the running of the ng test acceptance tests (xdescribe) in case anyone else wants to take a look in the meantime.

I added the karma args and defaulted it to be a single-run to alleviate confusion "why's that still running"

[Brocco]

Updated the readme to update the documentation on how to execute tests

[cironunes]

@Brocco can you rebase this with the latest changes from master?

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[jkuri]

Signed.

On 24 Jan 2016, at 03:17, googlebot [email protected] wrote:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

Please visit https://cla.developers.google.com/https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data https://cla.developers.google.com/clas and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/.
If you signed the CLA as a corporation, please let us know the company's name.
—
Reply to this email directly or view it on GitHub #86 (comment).

[Brocco]

I signed it!
On Jan 23, 2016 9:17 PM, "googlebot" [email protected] wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).

[image: 📝] Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.

• If you've already signed a CLA, it's possible we don't have your
  GitHub username or you're using a different email address. Check your
  existing CLA data https://cla.developers.google.com/clas and verify
  that your email is set on your git commits
  https://help.github.com/articles/setting-your-email-in-git/.
• If you signed the CLA as a corporation, please let us know the
  company's name.

—
Reply to this email directly or view it on GitHub
#86 (comment).

[cironunes]

@Brocco have you updated the PR?

I'm still seeing:

This branch is out-of-date with the base branch
Merge the latest changes from master into this branch.

[filipesilva]

Shouldn't these be in the same order as https://github.com/angular/angular-cli/blob/master/lib/broccoli/angular2-app.js#L21-L30 ?

[filipesilva]

Other than the comments I added in, lgtm.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}