Skip to content

Conversation

@pateash
Copy link
Contributor

@pateashpateash commented Apr 7, 2021

Closes: #15245

This is my first PR. I tried to follow the CONTRIBUTING guide step by step. It passed all the pre-commit tests.

My PR adds a new argument to DataprocCreateClusterOperator which allows user to pass custom image family while creating GCP DataProc cluster. any advice or suggestions are welcome.

@pateashpateash requested a review from turbaszek as a code ownerApril 7, 2021 11:32
@boring-cyborgboring-cyborgbot added area:providers provider:google Google (including GCP) related issues labels Apr 7, 2021
@boring-cyborg
Copy link

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

Copy link
Contributor

@marcosmarxmmarcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, overall LGTM;

@xinbinhuang
Copy link
Contributor

@asamasoma Thanks for the contribution! Can you also add an extra test case to verify the generated cluster config is as expected with custom_image_family and single_node?

@pateash
Copy link
ContributorAuthor

pateash commented Apr 18, 2021

@xinbinhuang Thanks for the review,
I have added a test case to verify the generated cluster config is as expected with custom_image_family and single_node.

…onfig is as expected with custom_image_family and single_node.
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@github-actionsgithub-actionsbot added the okay to merge It's ok to merge this PR as it does not require more tests label Apr 18, 2021
…ow-15245-passing-custom-image-family-name-to-the-dataprocclustercreateoperator
Copy link
Contributor

@xinbinhuangxinbinhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just need to remove the print statement in the test case, then we can merge it:)

@xinbinhuangxinbinhuang merged commit 6da36ba into apache:masterApr 18, 2021
@boring-cyborg
Copy link

Awesome work, congrats on your first merged pull request!

@pateashpateash deleted the airflow-15245-passing-custom-image-family-name-to-the-dataprocclustercreateoperator branch April 18, 2021 18:45
@pateashpateash changed the title [Airflow-15245] - passing custom image family name to the DataProcClusterCreateoperator#15245 - passing custom image family name to the DataProcClusterCreateoperatorApr 20, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providersokay to mergeIt's ok to merge this PR as it does not require more testsprovider:googleGoogle (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Passing Custom Image Family Name to the DataprocClusterCreateOperator()

4 participants

@pateash@xinbinhuang@marcosmarxm@turbaszek