- Notifications
You must be signed in to change notification settings - Fork 16.2k
#15245 - passing custom image family name to the DataProcClusterCreateoperator#15250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#15245 - passing custom image family name to the DataProcClusterCreateoperator #15250
Uh oh!
There was an error while loading. Please reload this page.
Conversation
pateash commented Apr 7, 2021 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
…cCreateClusterOperator Signed-off-by: ashish <[email protected]>
…age_family must not be passed Signed-off-by: ashish <[email protected]>
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
Signed-off-by: ashish <[email protected]>
…ow-15245-passing-custom-image-family-name-to-the-dataprocclustercreateoperator
marcosmarxm left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question, overall LGTM;
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
xinbinhuang commented Apr 18, 2021
@asamasoma Thanks for the contribution! Can you also add an extra test case to verify the generated cluster config is as expected with |
Co-authored-by: Xinbin Huang <[email protected]>
Co-authored-by: Xinbin Huang <[email protected]>
pateash commented Apr 18, 2021 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
@xinbinhuang Thanks for the review, |
…onfig is as expected with custom_image_family and single_node.
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
…ow-15245-passing-custom-image-family-name-to-the-dataprocclustercreateoperator
Uh oh!
There was an error while loading. Please reload this page.
xinbinhuang left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just need to remove the print statement in the test case, then we can merge it:)
Awesome work, congrats on your first merged pull request! |
Closes: #15245
This is my first PR. I tried to follow the CONTRIBUTING guide step by step. It passed all the pre-commit tests.
My PR adds a new argument to DataprocCreateClusterOperator which allows user to pass custom image family while creating GCP DataProc cluster. any advice or suggestions are welcome.