Skip to content

Conversation

@pateash
Copy link
Contributor

closes#15416


Description

Currently, when we run

breeze start-airflow

breeze doesn't load local tmux configuration file .tmux.conf and we get default tmux configuration inside the containers.

PR effect
After this change developers will be able to put their .tmux.conf file as /files/airflow-breeze-config/.tmux.conf
and Breeze will load local tmux configuration in to the containers and developers should be able to use their local configurations.

@pateashpateash requested review from ashb and potiuk as code ownersApril 20, 2021 13:58
@pateashpateash changed the title #15416 - breeze should load local tmux configuration in 'breeze start-airflow' Breeze should load local tmux configuration in 'breeze start-airflow' Apr 20, 2021
@potiuk
Copy link
Member

potiuk commented Apr 20, 2021

I guess, I have to update docs as well.

Indeed. Would be great to add it to BREEZE.rst, though we print it as output. I think we do not have the .env file mentioned there - so a small "customizing" environment chapter would be nice.

@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actionsgithub-actionsbot added the full tests needed We need to run full set of tests for this PR to merge label Apr 20, 2021
@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@potiukpotiuk merged commit 508cd39 into apache:masterApr 21, 2021
@pateashpateash deleted the #15416-breeze-should-load-local-tmux-configuration-in-start-airflow branch April 21, 2021 16:59
potiuk pushed a commit to potiuk/airflow that referenced this pull request May 6, 2021
potiuk pushed a commit to potiuk/airflow that referenced this pull request May 6, 2021
@potiukpotiuk added this to the Airflow 2.0.3 milestone May 9, 2021
@ashbashb modified the milestones: Airflow 2.0.3, Airflow 2.1May 18, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-toolsfull tests neededWe need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

breeze should load local tmux configuration in 'breeze start-airflow'

4 participants

@pateash@potiuk@uranusjr@ashb