Skip to content

Conversation

@pateash
Copy link
Contributor

closes: #20300


Description

Adding Github provider based on Python SDK https://github.com/PyGithub/PyGithub
The SDK has many objects which can be viewed at https://pygithub.readthedocs.io/en/latest/github_objects.html

Users can create their own custom operators leveraging the PyGithub SDK, either by leveraging Hook directly or building their operator on GithubOperator by providing method and method_args from PyGithub
results can be further processed by implementing result_processor method, please look into GithubTagSensor for reference.

github_operator = GithubOperator( task_id='github-test', github_method="get_repo", github_method_args={'full_name_or_id': 'apache/airflow'}, result_processor=lambda r: r.full_name, dag=self.dag, ) 

@pateashpateash changed the title 20300 add GitHub provider[WIP]: 20300 add GitHub providerJan 24, 2022
@pateashpateash changed the title [WIP]: 20300 add GitHub provider[WIP]: 20300- Adding GitHub providerJan 24, 2022
@potiukpotiuk changed the title [WIP]: 20300- Adding GitHub provider[WIP]: Adding GitHub providerJan 25, 2022
@potiukpotiuk changed the title [WIP]: Adding GitHub provider[WIP]: Add GitHub providerJan 25, 2022
Copy link
Member

@potiukpotiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice one!

I left a few comments, but it looks great already!

@pateashpateash requested a review from potiukJanuary 26, 2022 15:44
@pateashpateash changed the title [WIP]: Add GitHub providerAdding GitHub providerJan 26, 2022
@pateash
Copy link
ContributorAuthor

image

image

@pateash
Copy link
ContributorAuthor

image

@pateashpateashforce-pushed the 20300-Add-Github-provider branch from 3fcacda to 58e3f99CompareJanuary 26, 2022 15:49
@pateash
Copy link
ContributorAuthor

Hi @potiuk,
thanks for the comments, Please let me know if anything else needed.

@pateashpateash changed the title Adding GitHub providerWIP: Adding GitHub providerJan 26, 2022
@pateashpateash requested a review from eladkalJanuary 26, 2022 16:55
@pateashpateashforce-pushed the 20300-Add-Github-provider branch from 94c689a to 8369d9fCompareJanuary 28, 2022 12:24
Copy link
Contributor

@eladkaleladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@potiuk any further comments?

@potiukpotiuk merged commit 5d23fbe into apache:mainJan 28, 2022
@potiuk
Copy link
Member

Just in time for the January wave of Providers :)

@pateashpateash deleted the 20300-Add-Github-provider branch February 15, 2022 13:49
@jedcunninghamjedcunningham added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Mar 1, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-toolsarea:providerschangelog:skipChanges that should be skipped from the changelog (CI, tests, etc..)kind:documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Github provider

4 participants

@pateash@eladkal@potiuk@jedcunningham