Skip to content

Conversation

@nssalian
Copy link
Contributor

Closes#2911

Rationale for this change

PR #2906 added imports to tests/conftest.py that require pytest-lazy-fixture and sqlalchemy. The nightly build's wheel test uses a minimal environment that doesn't include these dependencies, causing tests/avro/test_decoder.py to fail when loading conftest.py.

Are these changes tested?

Yes. Reproduced locally by creating a minimal venv with only the original test dependencies, reproduced the failure, then verified the fix resolves it.

Are there any user-facing changes?

No

@nssaliannssalian marked this pull request as draft January 14, 2026 16:31
@nssaliannssalian marked this pull request as ready for review January 14, 2026 17:01
Copy link
Contributor

@kevinjqliukevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This makes sense, lets give this a try

@kevinjqliukevinjqliu merged commit 1fb817b into apache:mainJan 14, 2026
2 checks passed
@nssaliannssalian deleted the fix-2911 branch January 14, 2026 17:58
This was referenced Jan 14, 2026
kevinjqliu added a commit that referenced this pull request Jan 16, 2026
<!-- Thanks for opening a pull request! --> <!-- In the case this PR will resolve an issue, please replace ${GITHUB_ISSUE_ID} below with the actual Github issue id. --> <!-- Closes #${GITHUB_ISSUE_ID} --> # Rationale for this change Follow up to #2912 CI still fails with https://github.com/apache/iceberg-python/actions/runs/21004478697/job/60383069033 ``` Error: cibuildwheel: Command ['C:\\Users\\runneradmin\\AppData\\Local\\Temp\\cibw-run-0tbpuziz\\cp310-win_amd64\\venv-test\\Scripts\\pip.EXE', 'install', 'pytest==7.4.2', 'moto==5.0.1', 'pytest-lazy-fixture==0.6.3', 'sqlalchemy>=2.0.18,<3'] failed with code 1. Error: Process completed with exit code 1. ``` This PR fixes syncs the env with uv so we dont need to explicitly specify the deps here ## Are these changes tested? Yes https://github.com/apache/iceberg-python/actions/runs/21007310527 ## Are there any user-facing changes? <!-- In the case of user-facing changes, please add the changelog label. -->
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nightly build failing

2 participants

@nssalian@kevinjqliu