Update runAppInBackground method implementation for XCUITest#593

mykola-mokhnach · 2017-03-07T11:41:50Z

Change list

See details.

Types of changes

No changes in production code.
Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

This change is based on appium/appium-xcuitest-driver#381, which makes possible to minimize the application under test and then return to iOS springboard (emulates clicking Home button). The change is breaking since the format of input parameters has been changed for background API call (the old format is still supported, but shows deprecation warning).

TikhomirovSergey · 2017-03-07T19:54:11Z

ping @SrinivasanTarget

TikhomirovSergey

@mykola-mokhnach Hi
There are errors of generated javadoc.
Also. Could you provide some test?

mykola-mokhnach · 2017-03-07T20:12:31Z

Where to put the test (which file)?
Are tests independent? Does it break other tests if I put an app into background in my functional test?

saikrishna321 · 2017-03-08T00:34:24Z

@mykola-mokhnach

Where to put the test (which file)?
https://github.com/appium/java-client/blob/master/src/test/java/io/appium/java_client/ios/XCUIAutomationTest.java

mykola-mokhnach · 2017-03-08T14:39:19Z

added unit tests. Please let me know if anything else is missing.

TikhomirovSergey · 2017-03-09T20:43:00Z

@SrinivasanTarget loks ok.
Could you take a look and check it?

SrinivasanTarget · 2017-03-10T10:35:53Z

@mykola-mokhnach Can you please rebase it with master?

mykola-mokhnach · 2017-03-10T10:40:26Z

Squashed into single commit. There is nothing new in master so far

SrinivasanTarget · 2017-03-10T10:49:53Z

Cool @mykola-mokhnach Thanks. Branch looks clean now. Will review and merge this once #594 is fixed. @TikhomirovSergey is working on fix already.

SrinivasanTarget

@mykola-mokhnach

PR logically LGTM. But unfortunately it doesn't work for me.Can you look into it?
https://gist.github.com/SrinivasanTarget/e3b06763e17603e15a7e9cfa7407517d

SrinivasanTarget

/session/CEF9E752-32C3-4F1B-A5A0-7A33D464D307/wda/homescreen Do we have this endpoint handled in Appium?

mykola-mokhnach · 2017-03-14T16:53:22Z

Thanks for verification. Seems like there was some change in WDA API. I'll update this in Appium and let you know

SrinivasanTarget · 2017-03-14T16:53:56Z

I'll update this in Appium and let you know

Sure buddy

mykola-mokhnach · 2017-03-14T22:21:49Z

This PR should make it working

mykola-mokhnach · 2017-03-17T08:33:22Z

@SrinivasanTarget The fix has been merged to xcuitest driver and the stuff should work as expected now. Please make sure the xcuitest driver version is 2.21.0 or greater

SrinivasanTarget · 2017-03-17T08:38:14Z

Sure will close this soon.

…

On Fri 17 Mar, 2017, 2:03 PM Mykola Mokhnach, ***@***.***> wrote: @SrinivasanTarget <https://github.com/SrinivasanTarget> The fix has been merged to xcuitest driver and the stuff should work as expected now. Please make sure the xcuitest driver version is 2.21.0 or greater — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#593 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIfAJdh2jktnrUgAoigMtISjVQQxvhS9ks5rmkVTgaJpZM4MVX-7> .

SrinivasanTarget · 2017-03-17T23:11:27Z

src/test/java/io/appium/java_client/ios/XCUIAutomationTest.java

+@TestpublicvoidtestPutIntoBackgroundWithoutRestore(){
+finallongmsStarted = System.currentTimeMillis();
+driver.runAppInBackground(-1);
+assertThat(System.currentTimeMillis() - msStarted, lessThan(1000L));


Functionality worked as expected it didn't restore the app but i think it should also assert for greater than 1000ms. see below
java.lang.AssertionError:
Expected: a value less than <1000L>
but: <1080L> was greater than <1000L>
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at org.junit.Assert.assertThat(Assert.java:956) at org.junit.Assert.assertThat(Assert.java:923) at io.appium.java_client.ios.XCUIAutomationTest.testPutIntoBackgroundWithoutRestore(XCUIAutomationTest.java:64) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runner.JUnitCore.run(JUnitCore.java:137) at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68) at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:51) at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:237) at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at com.intellij.rt.execution.application.AppMain.main(AppMain.java:147)

Sure, this value, actually, depends on how fast the machine under test is. And Travis, as far as we can see, is quite slow :(

Yeah let's make it greater than for ideal situation.

Or is there anything else that we can assert apart form time?

We could assert some of application elements are not visible

yup sounds good to me

cool thanks

SrinivasanTarget · 2017-03-17T23:57:28Z

@mykola-mokhnach Will merge this once travis and codacy are happy. Will review other PR later today.

TikhomirovSergey requested review from SrinivasanTarget and TikhomirovSergey March 7, 2017 19:53

TikhomirovSergey added the iOS label Mar 7, 2017

TikhomirovSergey added this to the 5.0.0 milestone Mar 7, 2017

TikhomirovSergey suggested changes Mar 7, 2017
View reviewed changes

TikhomirovSergey approved these changes Mar 9, 2017
View reviewed changes

TikhomirovSergey force-pushed the master branch from 937cc91 to 1e2c86eCompare March 10, 2017 09:29

mykola-mokhnach force-pushed the new_background_app branch from bc78740 to 0e9b641Compare March 10, 2017 10:38

SrinivasanTarget requested changes Mar 14, 2017
View reviewed changes

SrinivasanTarget reviewed Mar 14, 2017
View reviewed changes

SrinivasanTarget requested changes Mar 17, 2017
View reviewed changes

Update runAppInBackground method implementation for XCUITest
7cdaa59

mykola-mokhnach force-pushed the new_background_app branch from 0e9b641 to 7cdaa59Compare March 17, 2017 23:51

SrinivasanTarget approved these changes Mar 17, 2017
View reviewed changes

SrinivasanTarget merged commit e387bec into appium:masterMar 18, 2017

mykola-mokhnach mentioned this pull request Mar 20, 2017
add access to WDA's homescreen press method appium/appium#7741
Closed

mykola-mokhnach deleted the new_background_app branch April 3, 2017 20:42

ghost mentioned this pull request Apr 25, 2017
Xcode 8.3.2 (iOS 10.3) tests that call runAppInBackground(int) throw an exception appium/appium#8323
Closed

Uh oh!

Update runAppInBackground method implementation for XCUITest#593

Update runAppInBackground method implementation for XCUITest #593

Uh oh!

Conversation

mykola-mokhnach commented Mar 7, 2017• edited by SrinivasanTarget Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Change list

Types of changes

Details

Uh oh!

TikhomirovSergey commented Mar 7, 2017

Uh oh!

TikhomirovSergey left a comment

Choose a reason for hiding this comment

Uh oh!

mykola-mokhnach commented Mar 7, 2017

Uh oh!

saikrishna321 commented Mar 8, 2017

Uh oh!

mykola-mokhnach commented Mar 8, 2017

Uh oh!

TikhomirovSergey commented Mar 9, 2017

Uh oh!

SrinivasanTarget commented Mar 10, 2017

Uh oh!

mykola-mokhnach commented Mar 10, 2017

Uh oh!

SrinivasanTarget commented Mar 10, 2017

Uh oh!

SrinivasanTarget left a comment

Choose a reason for hiding this comment

Uh oh!

SrinivasanTarget left a comment

Choose a reason for hiding this comment

Uh oh!

mykola-mokhnach commented Mar 14, 2017

Uh oh!

SrinivasanTarget commented Mar 14, 2017

Uh oh!

mykola-mokhnach commented Mar 14, 2017

Uh oh!

mykola-mokhnach commented Mar 17, 2017

Uh oh!

SrinivasanTarget commented Mar 17, 2017 via email

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SrinivasanTarget commented Mar 17, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mykola-mokhnach commented Mar 7, 2017•
edited by SrinivasanTarget
Loading