Fix build failure on Swift Playground#336
Open
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
phausler commented Oct 15, 2024
@swift-ci please test |
jessezamora commented Dec 17, 2024
Good to merge? LOL |
Author
Swift Playground 4.6 was released today, but it still has this issue. |
kkebo changed the title kkeboforce-pushed the fix-swift-playgrounds branch from ad84e42 to 74ee419Comparekkeboforce-pushed the fix-swift-playgrounds branch 3 times, most recently from 01d54ab to 472187aCompare
The PR apple#311 introduced `Context.environment`, so that swift-async-algorithm can no longer be used in the Swift Playground. However, `Context.environment` is equivalent to `ProcessInfo.processInfo.environment`, so this is an unnecessary sacrifice. This change is intended to fix that.
kkeboforce-pushed the fix-swift-playgrounds branch from 472187a to 40af8ccCompareSign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes#316
The PR #311 introduced
Context.environment, so that swift-async-algorithm can no longer be used in the Swift Playground.However,
Context.environmentis equivalent toProcessInfo.processInfo.environment, so this is an unnecessary sacrifice.This change is intended to fix that.