This repository was archived by the owner on Feb 28, 2024. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork 28
Deprecate library#118
Merged
leonardocavagnis merged 5 commits into arduino-libraries:master from leonardocavagnis:deprecationFeb 27, 2024
Merged
Deprecate library #118
leonardocavagnis merged 5 commits into arduino-libraries:master from leonardocavagnis:deprecationFeb 27, 2024
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
leonardocavagnis commented Jan 12, 2024 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
per1234 suggested changes Jan 12, 2024
Uh oh!
There was an error while loading. Please reload this page.
Memory usage change @ 719b570
Click for full report table
Click for full report CSV |
Co-authored-by: per1234 <[email protected]>
Memory usage change @ f0c30b5
Click for full report table
Click for full report CSV |
per1234 suggested changes Jan 15, 2024
Uh oh!
There was an error while loading. Please reload this page.
per1234 approved these changes Jan 16, 2024
Contributor
per1234 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @leonardocavagnis!
sebromero suggested changes Jan 18, 2024
Contributor
sebromero left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small suggestions, otherwise looks good.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Sebastian Romero <[email protected]>
Memory usage change @ a7a19c0
Click for full report table
Click for full report CSV |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding deprecation note to README, library.properties and examples.
This library will be replaced and no longer maintained.
Please,
@sebromero check if everything is fine
@per1234 check if I've followed all the necessary steps for deprecating a library correctly
Thanks! ✌️
UPDATE
Migration guide here.