Fix duplicate OPTIONS method error for paths with trailing slash#3844
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes#3816
This PR fixes the issue where enabling CORS on an API with paths that differ only by a trailing slash (e.g.,
/datasetsand/datasets/) causes API Gateway to throw an error:Problem
When CORS is enabled, SAM adds OPTIONS methods to all paths. However, API Gateway treats
/pathand/path/as the same resource. If both paths exist in the template, SAM was adding OPTIONS to both separately, causing a duplicate method error.Solution
The fix normalizes paths before adding CORS OPTIONS methods:
/)Changes
Modified files:
samtranslator/model/api/api_generator.py: Added path normalization in_add_cors()methodtests/model/api/test_api_generator.py: Added unit testtest_add_cors_with_trailing_slash_pathsTesting
✅ Unit Tests
test_add_cors_with_trailing_slash_pathsthat verifies:/datasets(POST) and/datasets/(PUT) are correctly handled✅ Integration Tests
✅ Real-world Validation
Related Issues
Closes#3816
Checklist:
developbranch