This repository was archived by the owner on Aug 31, 2018. It is now read-only.
worker: restrict supported extensions#117
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Only allow `.js` and `.mjs` extensions to provide future-proofing for file type detection.
TimothyGu approved these changes Oct 22, 2017
Member
TimothyGu left a comment
TimothyGu left a comment There was a problem hiding this comment.
This should IMO be squashed into the main PR as well.
ContributorAuthor
addaleax commented Oct 22, 2017
@TimothyGu I merged the main impl PR @ #110 so that most of the dependent bits of code can be unblocked. Also, although the argument doesn’t really the case here, I like doing work in small chunks because it helps reviewers :) |
ghost approved these changes Oct 22, 2017
ghost commented Oct 22, 2017
i agree with @addaleax, even though it's a lot of prs, it splits it up into manageable pieces pretty nicely! |
Qard approved these changes Oct 22, 2017
addaleax pushed a commit that referenced this pull request Oct 24, 2017
Only allow `.js` and `.mjs` extensions to provide future-proofing for file type detection. PR-URL: #117 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Olivia Hugger <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
addaleax added a commit that referenced this pull request Oct 24, 2017
PR-URL: #117 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Olivia Hugger <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
ContributorAuthor
addaleax commented Oct 24, 2017
addaleax added a commit to addaleax/node that referenced this pull request Jun 5, 2018
Implement multi-threading support for most of the API. Thanks to Stephen Belanger for reviewing this change in its original form, to Olivia Hugger for reviewing the documentation and some of the tests coming along with it, and to Alexey Orlenko and Timothy Gu for reviewing other parts of the tests. Refs: ayojs/ayo#110 Refs: ayojs/ayo#114 Refs: ayojs/ayo#117
addaleax pushed a commit to addaleax/node that referenced this pull request Jun 5, 2018
Only allow `.js` and `.mjs` extensions to provide future-proofing for file type detection. Refs: ayojs/ayo#117 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Olivia Hugger <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
addaleax added a commit to addaleax/node that referenced this pull request Jun 5, 2018
Implement multi-threading support for most of the API. Thanks to Stephen Belanger for reviewing this change in its original form, to Olivia Hugger for reviewing the documentation and some of the tests coming along with it, and to Alexey Orlenko and Timothy Gu for reviewing other parts of the tests. Refs: ayojs/ayo#110 Refs: ayojs/ayo#114 Refs: ayojs/ayo#117
addaleax pushed a commit to addaleax/node that referenced this pull request Jun 5, 2018
Only allow `.js` and `.mjs` extensions to provide future-proofing for file type detection. Refs: ayojs/ayo#117 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Olivia Hugger <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
addaleax added a commit to nodejs/node that referenced this pull request Jun 6, 2018
Implement multi-threading support for most of the API. Thanks to Stephen Belanger for reviewing this change in its original form, to Olivia Hugger for reviewing the documentation and some of the tests coming along with it, and to Alexey Orlenko and Timothy Gu for reviewing other parts of the tests. Refs: ayojs/ayo#110 Refs: ayojs/ayo#114 Refs: ayojs/ayo#117 PR-URL: #20876 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
addaleax pushed a commit to nodejs/node that referenced this pull request Jun 6, 2018
Only allow `.js` and `.mjs` extensions to provide future-proofing for file type detection. Refs: ayojs/ayo#117 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Olivia Hugger <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> PR-URL: #20876 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
targos pushed a commit to nodejs/node that referenced this pull request Jun 7, 2018
Implement multi-threading support for most of the API. Thanks to Stephen Belanger for reviewing this change in its original form, to Olivia Hugger for reviewing the documentation and some of the tests coming along with it, and to Alexey Orlenko and Timothy Gu for reviewing other parts of the tests. Refs: ayojs/ayo#110 Refs: ayojs/ayo#114 Refs: ayojs/ayo#117 PR-URL: #20876 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
targos pushed a commit to nodejs/node that referenced this pull request Jun 7, 2018
Only allow `.js` and `.mjs` extensions to provide future-proofing for file type detection. Refs: ayojs/ayo#117 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Olivia Hugger <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> PR-URL: #20876 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
targos pushed a commit to nodejs/node that referenced this pull request Jun 13, 2018
Implement multi-threading support for most of the API. Thanks to Stephen Belanger for reviewing this change in its original form, to Olivia Hugger for reviewing the documentation and some of the tests coming along with it, and to Alexey Orlenko and Timothy Gu for reviewing other parts of the tests. Refs: ayojs/ayo#110 Refs: ayojs/ayo#114 Refs: ayojs/ayo#117 PR-URL: #20876 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
targos pushed a commit to nodejs/node that referenced this pull request Jun 13, 2018
Only allow `.js` and `.mjs` extensions to provide future-proofing for file type detection. Refs: ayojs/ayo#117 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Olivia Hugger <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> PR-URL: #20876 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
worker