Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Conversation

@mansourmoufid
Copy link
Contributor

I found some duplicates in the APK output by briefcase:

(bee-venv) helloworld % unzip -l "android/gradle/Hello World/app/build/outputs/apk/debug/app-debug.apk" | sort -k1 647820 01-01-1981 01:01 lib/armeabi-v7a/libssl.so 647820 01-01-1981 01:01 lib/armeabi-v7a/libssl1.1.so ... 746032 01-01-1981 01:01 lib/x86/libssl.so 746032 01-01-1981 01:01 lib/x86/libssl1.1.so ... 753312 01-01-1981 01:01 lib/arm64-v8a/libssl.so 753312 01-01-1981 01:01 lib/arm64-v8a/libssl1.1.so 770064 01-01-1981 01:01 lib/x86_64/libssl.so 770064 01-01-1981 01:01 lib/x86_64/libssl1.1.so ... 2733640 01-01-1981 01:01 lib/armeabi-v7a/libcrypto.so 2733640 01-01-1981 01:01 lib/armeabi-v7a/libcrypto1.1.so ... 3278428 01-01-1981 01:01 lib/x86/libcrypto.so 3278428 01-01-1981 01:01 lib/x86/libcrypto1.1.so 3413544 01-01-1981 01:01 lib/arm64-v8a/libcrypto.so 3413544 01-01-1981 01:01 lib/arm64-v8a/libcrypto1.1.so ... 3582328 01-01-1981 01:01 lib/x86_64/libcrypto.so 3582328 01-01-1981 01:01 lib/x86_64/libcrypto1.1.so 

These files are from Python-3.7-Android-support.b7.zip. I guess these were symbolic links originally (libcrypto.so → libcrypto1.1.so).

By default the zip command follows symbolic links instead of including the link itself, this behaviour is changed by the -y (--symlinks) option.

I hope someone can test this as I am not familiar enough with Docker.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

Copy link
Member

@freakboy3742freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great cleanup - good for another couple of MB!

@freakboy3742freakboy3742 merged commit 2b72967 into beeware:mainMay 25, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mansourmoufid@freakboy3742