Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions github_webhook/webhook.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@
import logging

import six
import concurrent.futures
from flask import abort, request


Expand All@@ -16,10 +17,10 @@ class Webhook(object):
:param secret: Optional secret, used to authenticate the hook comes from Github
"""

def __init__(self, app, endpoint='/postreceive', secret=None):
def __init__(self, app, endpoint='/postreceive', secret=None, max_workers=2):
app.add_url_rule(endpoint, view_func=self._postreceive,
methods=['POST'])

self._executor = concurrent.futures.ThreadPoolExecutor(max_workers)
self._hooks = collections.defaultdict(list)
self._logger = logging.getLogger('webhook')
if secret is not None and not isinstance(secret, six.binary_type):
Expand DownExpand Up@@ -70,7 +71,7 @@ def _postreceive(self):
'%s (%s)', _format_event(event_type, data), _get_header('X-Github-Delivery'))

for hook in self._hooks.get(event_type, []):
hook(data)
self._executor.submit(hook, data)

return '', 204

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
author_email="achamberlai9@bloomberg.net, fphillips7@bloomberg.net, dkiss1@bloomberg.net, dbeer1@bloomberg.net",
license='Apache 2.0',
packages=["github_webhook"],
install_requires=['flask', 'six'],
install_requires=['flask', 'six', 'future;python_version<"3"'],
tests_require=['mock', 'nose'],

classifiers=[
Expand Down