Skip to content

Conversation

@denzor200
Copy link
Contributor

Hello, i have an interest to be contributor of this library. I decided to start with this small PR to get experience and to receive feedback and "ping response" from community.

@denzor200
Copy link
ContributorAuthor

CI is broken, so this PR tested here: https://godbolt.org/z/b4vGMnK55

@jgopel
Copy link
Contributor

question: Forgive my ignorance - why not just use a std::move_iterator? What does this accomplish that that doesn't already do?

@denzor200
Copy link
ContributorAuthor

why not just use a std::move_iterator?

I had same question for std::move, but it exists. Look:

std::move(v.begin(), v.end(), std::back_inserter(l)); 

does the same result as:

std::copy(std::make_move_iterator(v.begin()), std::make_move_iterator(v.end()), std::back_inserter(l)); 

What does this accomplish that that doesn't already do?

just readability, and those people who use boost::algorithm::copy_while and boost::algorithm::copy_until also need for move_while and move_until.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@denzor200@jgopel