Python 3 and more#36
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 2 commits January 14, 2021 13:19
- remove requesocks hard dependency - Ran code through Black linter/formater - Modify to use Geckodriver by default, PhantomJS seemed defunct
Owner
breenmachine commented Jan 14, 2021
Thanks so much! I've been meaning to fix this code for ages and haven't gotten around to it. I'll test and merge this tomorrow. |
ContributorAuthor
jesse-osiecki commented Jan 14, 2021 via email
It’s the least I could do! It’s been very useful lately. Please let me know if anything is broken and needs changes, but “it works for me” — Jesse … On Jan 14, 2021, at 16:31, Stephen Breen ***@***.***> wrote: Thanks so much! I've been meaning to fix this code for ages and haven't gotten around to it. I'll test and merge this tomorrow. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. |
- yapf reordered imports
ContributorAuthor
jesse-osiecki commented Jan 15, 2021
I'm adding a few more things today, the socket library was missing in imports, masscan xml support (hopefully), among other things |
added 2 commits January 15, 2021 14:43
Change Firefox headless option to use non-deprecated method add import socket
Owner
breenmachine commented Jan 24, 2021
Had some time to try it out and looks good! The cluster script needs some updates as well but I'll take care of that. Thanks again! |
ContributorAuthor
jesse-osiecki commented Jan 24, 2021 via email
If you want any help let me know, I’d be happy to assist — Jesse … On Jan 24, 2021, at 10:43, Stephen Breen ***@***.***> wrote: Had some time to try it out and looks good! The cluster script needs some updates as well but I'll take care of that. Thanks again! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove PhantomJS
Default to Firefox
Convert code to work with Python3
Run Black and yapf against source file
Update Dockerfile to use ubuntu 20.04 and apt geckodriver, fix dependencies