fix docker, disk_quota and health+readiness check type serialization#1261
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
anthonydahanne commented Feb 11, 2025
Hello @schulzh , thank you for your contribution! |
ContributorAuthor
schulzh commented Feb 16, 2025
Hi @anthonydahanne , I've added a unit test, could you take a look again? |
schulzh changed the title schulzh changed the title ContributorAuthor
schulzh commented Feb 21, 2025
Hi @anthonydahanne , I've added two more serialization fixes to the PR. |
Contributor
Kehrlann commented Jun 10, 2025
Hi @schulzh ! Thanks for your contribution. Would you mind rebasing on |
ContributorAuthor
schulzh commented Jun 10, 2025
Hi @Kehrlann , i've updated the branch. |
Kehrlann approved these changes Jun 10, 2025
Contributor
Kehrlann left a comment
Kehrlann left a comment There was a problem hiding this comment.
Looks good!
I was hoping for a rebase rather than a merge, but that's OK.
Kehrlann merged commit e18f771 into cloudfoundry:main 5 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two issues we've encountered with the manifest serialization.
The first is that docker was not serialized as a deep structure, but as a string (java object representation), which breaks the yaml. The second issue is that the disk quota was not serialized with the correct field name.