Skip to content

Conversation

@BioPhoton
Copy link
Collaborator

This PR:

  • removes the generator to add a target to a project. from V19 on this is done over plugins

@nx-cloud
Copy link

nx-cloudbot commented Sep 6, 2025

View your CI Pipeline Execution ↗ for commit 7b131b3

CommandStatusDurationResult
nx code-pushup --nx-bail -- compare✅ Succeeded1m 3sView ↗
nx code-pushup --nx-bail --✅ Succeeded1m 28sView ↗
nx code-pushup --nx-bail -- print-config --outp...✅ Succeeded4m 11sView ↗

☁️ Nx Cloud last updated this comment at 2025-09-06 23:57:13 UTC

@pkg-pr-new
Copy link

pkg-pr-newbot commented Sep 6, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1110 

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1110 

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1110 

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1110 

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1110 

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1110 

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1110 

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1110 

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1110 

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1110 

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1110 

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1110 

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1110 

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1110 

commit: 7b131b3

@BioPhotonBioPhoton changed the title refactor: remove target generator in favore of task inferencerefactor: remove target generator in favour of task inferenceSep 6, 2025
@github-actions
Copy link
Contributor

github-actionsbot commented Sep 6, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit e41c6fa with previous commit c7d314e.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category⭐ Previous score⭐ Current score🔄 Score change
Performance🔴 37🔴 35↓ −1.9
Code coverage🟡 90🟡 90↓ −0.1
Documentation🔴 24🔴 24↑ +0.1
Security🟡 64🟡 64
Updates🟡 85🟡 85
Accessibility🟢 92🟢 92
Best Practices🟢 100🟢 100
SEO🟡 61🟡 61
Type Safety🟢 100🟢 100
Bug prevention🟢 100🟢 100
Miscellaneous🟢 100🟢 100
Code style🟢 100🟢 100
👍 1 group improved, 👎 2 groups regressed, 👍 1 audit improved, 👎 6 audits regressed, 16 audits changed without impacting score

🗃️ Groups

🔌 Plugin🗃️ Group⭐ Previous score⭐ Current score🔄 Score change
LighthousePerformance🔴 37🔴 35↓ −1.9
Code coverageCode coverage metrics🟡 90🟡 90↓ −0.1
JSDoc coverageDocumentation coverage🔴 24🔴 24↑ +0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin🛡️ Audit📏 Previous value📏 Current value🔄 Value change
LighthouseSpeed Index🟥 5.8 s🟥 6.5 s↑ +11.4 %
LighthouseTotal Blocking Time🟥 2,000 ms🟥 2,480 ms↑ +23.6 %
LighthouseTime to Interactive🟥 16.1 s🟥 17.1 s↑ +6 %
Code coverageLine coverage🟨 86.3 %🟨 86.2 %↓ −0.1 %
JSDoc coverageFunctions coverage🟥 521 undocumented functions🟥 520 undocumented functions↓ −0.2 %
Code coverageBranch coverage🟨 85.5 %🟨 85.5 %↓ −0.1 %
Code coverageFunction coverage🟩 92.3 %🟩 92.3 %↓ −0.1 %
LighthouseAvoids enormous network payloads🟨 Total size was 2,683 KiB🟨 Total size was 2,726 KiB↑ +1.6 %
LighthouseUses efficient cache policy on static assets🟨 30 resources found🟨 30 resources found↓ −0.4 %
LighthouseMinimizes main-thread work🟥 9.4 s🟥 11.6 s↑ +23 %
LighthouseJavaScript execution time🟥 4.1 s🟥 5.1 s↑ +24.4 %
LighthouseMetrics🟩 100%🟩 100%↑ +6 %
LighthouseLargest Contentful Paint🟥 11.1 s🟥 10.8 s↓ −2.4 %
LighthouseServer Backend Latencies🟩 980 ms🟩 1,160 ms↑ +18.2 %
LighthouseRemove duplicate modules in JavaScript bundles🟥 Potential savings of 96 KiB🟥 Potential savings of 81 KiB↓ −33.3 %
LighthouseReduce unused CSS🟥 Potential savings of 113 KiB🟥 Potential savings of 113 KiB↓ −23.3 %
LighthouseReduce unused JavaScript🟥 Potential savings of 604 KiB🟥 Potential savings of 590 KiB↓ −15.6 %
LighthouseInitial server response time was short🟩 Root document took 420 ms🟩 Root document took 550 ms↑ +29.7 %
LighthouseNetwork Round Trip Times🟩 20 ms🟩 70 ms↑ +269 %
LighthouseMax Potential First Input Delay🟥 760 ms🟥 810 ms↑ +6.3 %
LighthouseAvoids an excessive DOM size🟥 2,296 elements🟥 2,288 elements↓ −0.3 %
LighthouseFirst Contentful Paint🟥 3.0 s🟥 3.0 s↓ −0.1 %
LighthouseCumulative Layout Shift🟩 0🟩 0↑ +∞ %

587 other audits are unchanged.

@BioPhotonBioPhoton marked this pull request as ready for review September 7, 2025 18:13
@BioPhotonBioPhoton merged commit d5ca550 into mainOct 6, 2025
17 checks passed
@BioPhotonBioPhoton deleted the fix/nx-plugin/remove-target-generator branch October 6, 2025 16:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@BioPhoton@matejchalk