Skip to content

Update Code to 1.83.1#6488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
code-asher merged 2 commits into from
Oct 19, 2023
Merged

Update Code to 1.83.1 #6488

code-asher merged 2 commits into from
Oct 19, 2023

Conversation

@benz0li
Copy link
Contributor

@benz0libenz0li commented Oct 14, 2023

Fixes#6475

@benz0libenz0li requested a review from a team as a code ownerOctober 14, 2023 15:00
@benz0li
Copy link
ContributorAuthor

benz0li commented Oct 14, 2023

Ping @code-asher.

Please review and let the checks run.

Should the Safari error still occur: Please resolve.

Thank you.

@benz0li
Copy link
ContributorAuthor

benz0li commented Oct 14, 2023

code-server-4.18.0-rc.1-linux-amd64.tar.gz is deployed at https://coder.jupyter.b-data.ch; Image R (base:test-devtools-docker).

Functionality [modified by patches] tested and found to work:

  • base-path
  • cli-window-open
  • local-storage
  • marketplace
  • proxy-url
  • service-worker
  • webview

Jupyter Notebooks also work fine:

  • ms-toolsai.jupyter@2023.9.100
  • ms-python.python@2023.18.0

@code-asher
Copy link
Member

code-asher commented Oct 16, 2023•
edited
Loading

I need to fix those checks so they run for repeat contributors.

If Safari is still an issue I should be able to fix it this week.

@code-asher
Patch out lookbehind for Safari support
24c56c4
Not sure why it needs a lookbehind unless a number followed by a capital letter is not supposed to be considered a new word, which seems wrong to me. The tests do not contain any numbers so I can only guess.
@code-ashercode-asher enabled auto-merge (squash) October 19, 2023 00:13
@code-ashercode-asher merged commit d7a2b49 into coder:mainOct 19, 2023
@benz0li
Copy link
ContributorAuthor

benz0li commented Oct 20, 2023

@code-asher I have also smoke-testedcode-server-4.18.0-rc.1-linux-amd64.tar.gz from https://github.com/coder/code-server/releases/tag/v4.18.0-rc.1.

Same (positive) results as #6488 (comment).

@code-asher
Copy link
Member

code-asher commented Oct 20, 2023

Awesome, thank you. I think I will promote the release today.

yiliang114 pushed a commit to yiliang114/code-server that referenced this pull request Jan 23, 2025
@benz0li@code-asher@yiliang114
Update Code to 1.83.1 (coder#6488)
5189799
* Update Code to 1.83.1 * Patch out lookbehind for Safari support Not sure why it needs a lookbehind unless a number followed by a capital letter is not supposed to be considered a new word, which seems wrong to me. The tests do not contain any numbers so I can only guess. --------- Co-authored-by: Asher <ash@coder.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@code-ashercode-ashercode-asher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feat]: Update Code to 1.83

2 participants

@benz0li@code-asher