chore: set minimum coder server version to v2.24.3#215
+5 −3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This was referenced Aug 4, 2025
MemberAuthor
deansheather approved these changes Aug 4, 2025
ethanndicksonforce-pushed the ethan/progress-auto-start branch from 60f8964 to acf0aebCompareethanndicksonforce-pushed the ethan/bump-minimum-coder-version branch from 29b1d77 to 8f34725Compareethanndicksonforce-pushed the ethan/progress-auto-start branch from acf0aeb to f3468dbCompareethanndicksonforce-pushed the ethan/bump-minimum-coder-version branch from 8f34725 to 732f055Compareethanndickson changed the base branch from ethan/progress-auto-start to graphite-base/215ethanndicksonforce-pushed the ethan/bump-minimum-coder-version branch from 732f055 to 18604cdCompareethanndickson changed the base branch from graphite-base/215 to ethan/run-reopened-gui-app-as-userethanndicksonforce-pushed the ethan/run-reopened-gui-app-as-user branch from 2794fe6 to f404c56Compareethanndicksonforce-pushed the ethan/bump-minimum-coder-version branch 2 times, most recently from a28b21c to 3a4e672CompareThere was a problem hiding this comment.
Pull Request Overview
This PR updates the minimum required Coder server version from v2.24.2 to v2.25.0 to support VPN daemon functionality on macOS CLI. The change is necessary because the vpn-daemon command is only available in Coder server v2.25.0 and later versions.
- Updates minimum Coder version requirement from v2.24.2 to v2.25.0
- Adds VPNLib framework dependency to the project configuration
- Updates test to dynamically reference the minimum version constant
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Coder-Desktop/project.yml | Adds VPNLib framework as a non-embedded dependency |
| Coder-Desktop/VPNLib/Validate.swift | Updates minimum Coder version constant from "2.24.2" to "2.25.0" |
| Coder-Desktop/Coder-DesktopTests/LoginFormTests.swift | Updates test to use dynamic version reference instead of hardcoded value |
Uh oh!
There was an error while loading. Please reload this page.
ethanndicksonforce-pushed the ethan/bump-minimum-coder-version branch from 3a4e672 to 8edcc5aCompareethanndicksonforce-pushed the ethan/run-reopened-gui-app-as-user branch from f404c56 to 0d77ec3Compareethanndickson changed the base branch from ethan/run-reopened-gui-app-as-user to graphite-base/215ethanndicksonforce-pushed the graphite-base/215 branch from 0d77ec3 to 4ba6ca3Compareethanndicksonforce-pushed the ethan/bump-minimum-coder-version branch from 8edcc5a to 6d8c03aCompare
ethanndicksonforce-pushed the ethan/bump-minimum-coder-version branch from 6d8c03a to c7bd12aCompare
ethanndicksonforce-pushed the ethan/bump-minimum-coder-version branch from c7bd12a to 4352ef6Compareethanndickson changed the title MemberAuthor
Merge activity
|
ethanndickson merged commit f5d0741 into main 4 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requirement is introduced by #210, as the
vpn-daemoncommand on the macOS CLI isn't present on prior versions.(2.24.3 isn't out yet, but when it does come out, it'll be compatible. 2.25 is out, and it's compatible)