Close should guarantee no more goroutines

[kylecarbs]

If Close is called after the HTTP server has been closed, a goroutine currently leaks.

package main

import (
	"context"
	"net/http"
	"net/http/httptest"

	"go.uber.org/goleak"
	"nhooyr.io/websocket"
)

func main(){
	done := make(chan struct{})
	srv := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request){
		conn, err := websocket.Accept(rw, r, nil)
		if err != nil{
			panic(err)
		}
		close(done)
		conn.Close(websocket.StatusNormalClosure, "")
	}))
	_, _, err := websocket.Dial(context.Background(), srv.URL, nil)
	if err != nil{
		panic(err)
	}
	<-done
	srv.Close()
	err = goleak.Find()
	if err != nil{
		panic(err)
	}
}

[kylecarbs]

Nevermind, it shouldn't. The connection should always send a closure so the opposing end doesn't timeout on the connection.

[nhooyr]

Nah this is an issue. I forgot to respond. Glad I remembered this lol.

After Close() returns, you should be guaranteed that there are no more goroutines for the websocket. This is currently not the case.

[nhooyr]

Fixed in dev.