Skip to content

Conversation

@noirbizarre
Copy link
Member

Description

typing-extensions is not installed for Python 3.11+, so fix the import properly.

Note

CI was not failing as typing-extensions is a transitive dependency of multiple test/lint dependencies but is missing as soon as commitizen is installed alone.

Checklist

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

commitizen import/run does not fail on Selfgit s

Additional context

I might merge this PR without review as soon as the CI pass as the latest release is broken for Python 3.11+

@codecov
Copy link

codecovbot commented Mar 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (120d514) to head (db97e60).
Report is 573 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #1365 +/- ## ========================================== + Coverage 97.33% 97.69% +0.35%  ========================================== Files 42 57 +15 Lines 2104 2648 +544 ========================================== + Hits 2048 2587 +539 - Misses 56 61 +5 
FlagCoverage Δ
unittests97.69% <100.00%> (+0.35%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@noirbizarre
Copy link
MemberAuthor

Duplicate #1364

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@noirbizarre