fix(tags): import Self from typing for Python 3.11+#1365
Closed
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
typing-extensionsis not installed for Python 3.11+, so fix the import properly.Note
CI was not failing as
typing-extensionsis a transitive dependency of multiple test/lint dependencies but is missing as soon ascommitizenis installed alone.Checklist
poetry alllocally to ensure this change passes linter check and testExpected behavior
commitizenimport/run does not fail onSelfgit sAdditional context
I might merge this PR without review as soon as the CI pass as the latest release is broken for Python 3.11+