Skip to content

Conversation

@Bogay
Copy link
Contributor

@BogayBogay commented Sep 26, 2021

Description

Add some description related to #318 so that others may find the solution on documentation.

Checklist

  • Add test cases to all the changes you introduce
  • Run ./script/format and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Steps to Test This Pull Request

Additional context

Copy link
Member

@Lee-WLee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the minor documentation reword. Everything looks good. Thanks!

@BogayBogay requested a review from Lee-WSeptember 28, 2021 08:38
Copy link
Member

@Lee-WLee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry for the late review. As PyCon TW approaches, I get less time to devote to this project. Here are some errors I found on the changes.

You could test out through

poetry run mkdocs build poetry run mkdocs serve

Would be great if you could add these commands to "how to contribute" so that others can have a better idea on how to test documentation changes

@Lee-W
Copy link
Member

Also, you might need to rebase the latest master branch into this branch to pass the test fail

@Lee-W
Copy link
Member

Lee-W commented Oct 4, 2021

I still see the warning here.
image

Maybe you could try the following command to fix it

git remote add upstream [email protected]:commitizen-tools/commitizen.git git fetch upstream git rebase -i remotes/upstream/main

Bogayand others added 3 commits October 6, 2021 23:07
Provide the accurate versions that should solve this issue.
According to mkdoc documentation, link to another page in the same documentation can directly use file path. mkdoc documentation: https://www.mkdocs.org/user-guide/writing-your-docs/#linking-to-pages
@codecov
Copy link

codecovbot commented Oct 6, 2021

Codecov Report

Merging #431 (adea200) into master (7b7b0c9) will decrease coverage by 0.54%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #431 +/- ## ========================================== - Coverage 97.92% 97.37% -0.55%  ========================================== Files 39 39 Lines 1395 1409 +14 ========================================== + Hits 1366 1372 +6 - Misses 29 37 +8 
FlagCoverage Δ
unittests97.37% <ø> (-0.55%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
commitizen/config/base_config.py90.47% <0.00%> (-9.53%)⬇️
commitizen/cz/base.py97.22% <0.00%> (-2.78%)⬇️
commitizen/cli.py95.45% <0.00%> (-2.17%)⬇️
commitizen/git.py97.95% <0.00%> (-2.05%)⬇️
commitizen/__main__.py0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d2c3c2...adea200. Read the comment docs.

@Bogay
Copy link
ContributorAuthor

Bogay commented Oct 7, 2021

@Lee-W sorry for lately fix and thank you for helping me to rebase the upstream. I have finished those changes.
But the test coverage seems to decrease a little, I have no idea about that. Did I break something?

@BogayBogay requested a review from Lee-WOctober 7, 2021 08:09
These reference-style links should in `[link][id]` format instead of `[link](id)`.
@Lee-W
Copy link
Member

Lee-W commented Oct 9, 2021

@Bogay hmmm... that's weird. sometimes codecov just acts weird. never mind, let's merge it

@Lee-WLee-W merged commit 1ea05ac into commitizen-tools:masterOct 9, 2021
@BogayBogay deleted the doc/issue-318 branch November 20, 2021 02:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Bogay@Lee-W