This repository was archived by the owner on Mar 18, 2019. It is now read-only.
Descriptions of path fields and form fields default same value#145
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… fields defaults to "". This results in inconsistent presentation. This commit changes path fields default to "". Example before change: "/example-movies/v1/{id}/":{"put":{"description": "Updates the movie with passed movie id.", "parameters": [{"description": null, "required": true, "type": "string", "name": "id", "in": "path"},{"description": "", "required": true, "type": "string", "name": "title", "in": "formData"},{"description": "", "required": true, "type": "integer", "name": "rating", "in": "formData"}], "tags": ["example-movies"], "summary": "Updates the movie with passed movie id.", "operationId": "example-movies_v1_update", "consumes": ["application/x-www-form-urlencoded"], "responses":{"200":{"description": ""}}}, Example after change: "/example-movies/v1/{id}/":{"put":{"description": "Updates the movie with passed movie id.", "parameters": [{"description": "", "required": true, "type": "string", "name": "id", "in": "path"},{"description": "", "required": true, "type": "string", "name": "title", "in": "formData"},{"description": "", "required": true, "type": "integer", "name": "rating", "in": "formData"}], "tags": ["example-movies"], "summary": "Updates the movie with passed movie id.", "operationId": "example-movies_v1_update", "consumes": ["application/x-www-form-urlencoded"], "responses":{"200":{"description": ""}}} Description of id field changed to be consistent with title and rating fields' descriptions.
draskomikic commented Aug 24, 2017
Hi, please merge this pull request, I ran into same issue. |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… fields defaults to "". This results in inconsistent presentation. This commit changes path fields default to "".
Example before change:
"/example-movies/v1/{id}/":{"put":{"description": "Updates the movie with passed movie id.", "parameters": [{"description": null, "required": true, "type": "string", "name": "id", "in": "path"},{"description": "", "required": true, "type": "string", "name": "title", "in": "formData"},{"description": "", "required": true, "type": "integer", "name": "rating", "in": "formData"}], "tags": ["example-movies"], "summary": "Updates the movie with passed movie id.", "operationId": "example-movies_v1_update", "consumes": ["application/x-www-form-urlencoded"], "responses":{"200":{"description": ""}}},
Example after change:
"/example-movies/v1/{id}/":{"put":{"description": "Updates the movie with passed movie id.", "parameters": [{"description": "", "required": true, "type": "string", "name": "id", "in": "path"},{"description": "", "required": true, "type": "string", "name": "title", "in": "formData"},{"description": "", "required": true, "type": "integer", "name": "rating", "in": "formData"}], "tags": ["example-movies"], "summary": "Updates the movie with passed movie id.", "operationId": "example-movies_v1_update", "consumes": ["application/x-www-form-urlencoded"], "responses":{"200":{"description": ""}}}
Description of id field changed to be consistent with title and rating fields' descriptions.