🐛 Fix std includes for GTest.h#99
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Problem: - GTest.h uses constructs from `std::` without including them; in later versions of GoogleTest they are not necessarily transitively included. Solution: - Add includes for: - `iomanip` (`std::left`, `std::setw`) - `iostream` (`std::cout`, `std::endl`) - `tuple` (`std::tie`) - `type_traits` (various e.g. `std::is_same`)
kris-jusiak merged commit 467b07d into cpp-testing:master 3 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Contributor
kris-jusiak commented Dec 16, 2024
Thanks @elbeno |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
std::without including them; in later versions of GoogleTest they are not necessarily transitively included.Solution:
iomanip(std::left,std::setw)iostream(std::cout,std::endl)tuple(std::tie)type_traits(various e.g.std::is_same)