Handle coded index variable sizes#7
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 3 commits June 14, 2016 17:05
Since typelib ids are recorded as a GuidAttribute on an assembly, any guids from other CustomAttribute entries that are not on an assembly and are not constructed from a MemberRef can be discarded. MemberRef can be used to filter because GuidAttribute comes from mscorlib, so unless we're looking at mscorlib itself GuidAttribute will always be constructed using a MemberRef into another assembly.
If higher-index tables were not present, but their row count affects a coded index, the row_count array may not have been large enough to index for all tables the coded index can reach. As a fix, ensure the row_count table is always 64 entries.
ghost merged commit 
ghost commented Jun 15, 2016
Thanks! |
This pull request was closed.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a .NET assembly has a table large enough to trip a coded index into the larger 4-byte format rather than the 2-byte format, getnetguids.py would get totally thrown for a loop and read guids from somewhat arbitrary places.
is fix nao
Resolves#6
Also helps-with-but-doesn't-quite-solve #4, where there's also some strangeness at play with the
#-metadata tables' uncompressed data, rather than the normal#~compressed metadata.