Skip to content

main.cpp: error out when file/path provided by -I or -include=, or the input does not exist#435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
firewave merged 3 commits into from
Oct 1, 2025
Merged

main.cpp: error out when file/path provided by -I or -include=, or the input does not exist #435

firewave merged 3 commits into from
Oct 1, 2025

Conversation

@firewave
Copy link
Collaborator

@firewavefirewave commented Jun 11, 2025

No description provided.

@firewavefirewave marked this pull request as draft June 11, 2025 10:55
@firewavefirewave changed the title main.cpp: error out when file/path provided by -I or -include= do not existmain.cpp: error out when file/path provided by -I or -include= does not existJun 11, 2025
@firewavefirewaveforce-pushed the main-err branch 4 times, most recently from 807bbf5 to 97e7735CompareSeptember 10, 2025 11:57
@firewavefirewave changed the title main.cpp: error out when file/path provided by -I or -include= does not existmain.cpp: error out when file/path provided by -I or -include=, or the input do not existSep 10, 2025
@firewavefirewaveforce-pushed the main-err branch 2 times, most recently from e8947d4 to a179a19CompareSeptember 10, 2025 12:13
@firewave
Copy link
CollaboratorAuthor

firewave commented Sep 10, 2025

It will only fail when -is is specified. The check within simplecpp is still flawed.

These checks are important for #438. The code can be simplified if #339 has been merged.

@firewave
Copy link
CollaboratorAuthor

firewave commented Sep 10, 2025

It will only fail when -is is specified. The check within simplecpp is still flawed.

I added checks for all cases in the CLI. I filed #539 about improving the library.

@firewavefirewave marked this pull request as ready for review September 10, 2025 12:30
@firewavefirewave mentioned this pull request Sep 10, 2025
Closed
@firewavefirewave marked this pull request as draft September 10, 2025 12:59
@firewavefirewave marked this pull request as ready for review September 10, 2025 13:09
@firewavefirewave changed the title main.cpp: error out when file/path provided by -I or -include=, or the input do not existmain.cpp: error out when file/path provided by -I or -include=, or the input does not existSep 10, 2025
@firewavefirewave mentioned this pull request Sep 12, 2025
Merged
@firewavefirewave merged commit dcc4fdd into danmar:masterOct 1, 2025
16 checks passed
@firewavefirewave deleted the main-err branch October 1, 2025 15:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danmardanmardanmar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@firewave@danmar