- Notifications
You must be signed in to change notification settings - Fork 137
initial asyncio implementation after durable task asyncio work#827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
filintod commented Aug 20, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ext/dapr-ext-workflow/dapr/ext/workflow/workflow_activity_context.py Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| These examples mirror `examples/workflow/` but author orchestrators with `async def` using the | ||
| async workflow APIs. Activities remain regular functions unless noted. | ||
| How to run: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls add a venv reference in here too
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
examples/workflow/requirements.txt Outdated
| # dapr-ext-workflow-dev>=1.15.0.dev | ||
| # dapr-dev>=1.15.0.dev | ||
| # local development: install local packages in editable mode | ||
| # if using dev version of durabletask-python | ||
| -e../../../durabletask-python | ||
| # if using dev version of dapr-ext-workflow | ||
| -e../../ext/dapr-ext-workflow | ||
| -e../.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # dapr-ext-workflow-dev>=1.15.0.dev | |
| # dapr-dev>=1.15.0.dev | |
| # local development: install local packages in editable mode | |
| # if using dev version of durabletask-python | |
| -e ../../../durabletask-python | |
| # if using dev version of dapr-ext-workflow | |
| -e ../../ext/dapr-ext-workflow | |
| -e ../.. | |
| dapr-ext-workflow-dev>=1.15.0.dev | |
| dapr-dev>=1.15.0.dev | |
| # local development: install local packages in editable mode | |
| # if using dev version of durabletask-python | |
| # -e ../../../durabletask-python | |
| # if using dev version of dapr-ext-workflow | |
| # -e ../../ext/dapr-ext-workflow | |
| # -e ../.. |
ext/dapr-ext-workflow/Dapr-Workflow-Middleware-Outbound-Hooks.md Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
ext/dapr-ext-workflow/Dapr-Workflow-Middleware-Outbound-Hooks.md Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
ext/dapr-ext-workflow/Dapr-Workflow-Middleware-Outbound-Hooks.md Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
ext/dapr-ext-workflow/Dapr-Workflow-Middleware-Outbound-Hooks.md Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
ext/dapr-ext-workflow/Dapr-Workflow-Middleware-Outbound-Hooks.md Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
ext/dapr-ext-workflow/Dapr-Workflow-Middleware-Outbound-Hooks.md Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
ext/dapr-ext-workflow/Dapr-Workflow-Middleware-Outbound-Hooks.md Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
ext/dapr-ext-workflow/Dapr-Workflow-Middleware-Outbound-Hooks.md Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
ext/dapr-ext-workflow/Dapr-Workflow-Middleware-Outbound-Hooks.md Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
469c2e4 to 12269e7CompareUh oh!
There was an error while loading. Please reload this page.
| print(f'Child workflow returned {result_4}') | ||
| # Event vs timeout using when_any | ||
| event_1=ctx.wait_for_external_event(event_name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't these become async as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the runtime and the client are separate entities, as you have seen in your PR, so the client can be async or not
passuied commented Nov 26, 2025
@filintod looking at the examples you've added I think you would benefit from either waiting for my PR to be merged or merging that PR into your branch. |
filintod commented Dec 2, 2025
@passuied I'll wait for your PR to be merged, it complements this |
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
02b24ee to 06d6250Compare
Description
Make it possible to use python workflow that manages code using asyncio to retrofit code that is already written as async/await.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: