feat: Expose method to get manifest report#853
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
yxxhero commented Sep 8, 2025
@someshkoli what's your user case? |
ContributorAuthor
someshkoli commented Sep 8, 2025
Hey, so we want per resource diff / delta so we can further work on that data and output in seprate ui (not cli) |
Collaborator
yxxhero commented Sep 8, 2025
|
ContributorAuthor
someshkoli commented Sep 8, 2025
its internal method, there's an exposed method which does return the report, yeah i'll fix the signature |
yxxhero approved these changes Sep 9, 2025
someshkoliforce-pushed the ft-diff-report branch 2 times, most recently from ea5d6a9 to 57de4fdCompare
someshkoliforce-pushed the ft-diff-report branch from 57de4fd to 2eb4cd6CompareContributorAuthor
someshkoli commented Sep 10, 2025
@yxxhero ready for merge! |
Collaborator
yxxhero commented Sep 11, 2025
@mumoshu ping |
mumoshu approved these changes Sep 15, 2025
Collaborator
mumoshu left a comment
mumoshu left a comment There was a problem hiding this comment.
LGTM. Great work @someshkoli!
yxxhero merged commit 538d19c into databus23:master 17 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, we have a use case where we wanted diff reports rather than them being written to io.Writer, wanted to know your thoughts on getting this in, also open to further suggestions if there are existing ways to achieve this. LMK