add pipe_once special command#193
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
danp commented Nov 14, 2024
| else: | ||
| with tempfile.NamedTemporaryFile(delete=False) as f: | ||
| litecli.packages.special.execute(None, "\\pipe_once tee " + f.name) | ||
| litecli.packages.special.write_pipe_once("hello world") |
ContributorAuthor
There was a problem hiding this comment.
I changed this up from mycli, using tee to write the output to a file which can then be checked. But I did notice around here that mycli is using write_once in this test instead of write_pipe_once.
amjith reviewed Nov 16, 2024
tests/test_special_iocommands.py Outdated
| litecli.packages.special.write_pipe_once("hello world") | ||
| litecli.packages.special.unset_pipe_once_if_written() | ||
| else: | ||
| with tempfile.NamedTemporaryFile(delete=False) as f: |
ContributorAuthor
There was a problem hiding this comment.
Must have copied from above or elsewhere. But looks like if we know we aren't on windows we don't need this. Removed!
Member
amjith commented Nov 16, 2024
Apart from the one minor comment in the test, this looks good to me. |
Member
amjith commented Nov 16, 2024
Thank you for taking the time to do this. I appreciate it very much. Thanks for pointing out the oversight in mycli test. I'll fix that as well. 😄 |
Mostly copied from mycli. Add tests for once as part of getting that going. Updates #192
amjith approved these changes Nov 23, 2024
amjith merged commit 233d84b into dbcli:main 7 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates #192
Adds
\pipe_once/\|command for sending output to a program. Mostly copied from the same in mycli.I also added a test for
.onceas part of getting started and changed it slightly to be structured more like mycli's version.Checklist
CHANGELOG.mdfile.