Skip to content

Conversation

@hrodmn
Copy link

@zacdezgeo here is what I have so far. I added the section at the bottom to export a CSV for further analysis.

It would be great if you could fill in some more details in the text!

@review-notebook-app
Copy link

Check out this pull request on ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@hrodmnhrodmn requested a review from zacdezgeoMay 13, 2025 11:04
@hrodmnhrodmn mentioned this pull request May 13, 2025
@zacdezgeo
Copy link

@hrodmn; I reviewed your text and added some content to match the format of #2.

@kcarini; I think this would be ready for your review. Let me know if you want to pair on it!

@review-notebook-app
Copy link

review-notebook-appbot commented Jun 6, 2025

View / edit / reply to this conversation on ReviewNB

zacdezgeo commented on 2025-06-06T08:15:20Z
----------------------------------------------------------------

Line #16. import rioxarray # noqa 

is this an unused import? Greyed out in my editor locally.


@review-notebook-app
Copy link

review-notebook-appbot commented Jun 6, 2025

View / edit / reply to this conversation on ReviewNB

zacdezgeo commented on 2025-06-06T08:15:21Z
----------------------------------------------------------------

Line #1. field_gdf.explore(explore_column) 

No idea why the rendering is coming out as the entire globe in reviewNB. Renders appropriately locally.


@review-notebook-app
Copy link

review-notebook-appbot commented Jun 6, 2025

View / edit / reply to this conversation on ReviewNB

zacdezgeo commented on 2025-06-06T08:15:22Z
----------------------------------------------------------------

Line #3. parsed: odc.stac.ParsedItem, 

parsed and idx are unused in the function. Should we remove them from the function signature?


Copy link

@zacdezgeozacdezgeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hrodmn, again, really great work! I learned a lot reviewing the notebook. Your approach to anomaly detection and pulling in different data sources is well thought out. I can see others benefiting from it!

I reworded a few sections and moved/centered/resized the image in the introduction paragraph. I left a few comments about code things flagged by my editor, but I'll let you judge if they should be integrated.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@hrodmn@zacdezgeo