fix: corebluetooth peripheral name#447
Open
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
tternes commented Dec 3, 2025
Thank you for working on this! I should be able to do some testing this week and share feedback. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as well described here peripheral
local_nameandadvertisement_nameare two different things and it is justified to keep them separated as situation that local_name is not equal advertisement_name could happen in all platforms and can be implemented later as followup.currently it is quite unfortunate that the API changes the peripheral local_name (GAP) by joining those two values
changes:
Peripheral.advertisement_name- default Nonefix: #434