Ignore unsupported TestSources in SelfieTestExecutionListener#550
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Simon-Hostettler changed the title 
nedtwigg merged commit 310ed9d into diffplug:main 3 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Member
nedtwigg commented Sep 12, 2025
Shipped in |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for Issue #549.
As you have not yet set up logging, I did not want to make presumptions on which library to use for this, so for the moment I used the standard java util Logger.
I made the return value of parseClassTest nullable to deal with unrecognized sources, which seems okay as it is private and not used by any client code.
I tested this code by patching the libs of the example project given in Issue #549, the tests ran through successfully.