Skip to content

Added support for generic NativeCmd step#949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nedtwigg merged 2 commits into from
Sep 27, 2021
Merged

Added support for generic NativeCmd step #949

nedtwigg merged 2 commits into from
Sep 27, 2021

Conversation

@tisoft
Copy link
Contributor

@tisofttisoft commented Sep 24, 2021

Allows to call locally installed binaries to format files

@tisoft
Copy link
ContributorAuthor

tisoft commented Sep 24, 2021

Would like to use this, to call a custom formatter, that is installed locally, but can't be added as a "real" formatter into spotless.

TODO: Support writing the unformatted string to a temp file and read it back from another (or the same) file

nedtwigg
nedtwigg requested changes Sep 24, 2021
View reviewed changes
Copy link
Member

@nedtwiggnedtwigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool feature, needs docs and changelog entries (root and plugin-maven).

@nedtwigg
Copy link
Member

nedtwigg commented Sep 24, 2021•
edited
Loading

TODO: Support writing the unformatted string to a temp file and read it back from another (or the same) file

This feature is best left unimplemented, imo. stdin/stdout are perfectly suited for this purpose. Unless you absolutely, unavoidably need filebased-IO for a usecase you have right now, I think we're better off leaving this out. 100% guarantee people waste hours fiddling with the filename, whether its local or relative, tools that don't flush filesystem cache, etc, not to mention performance.

@tisoft
Copy link
ContributorAuthor

tisoft commented Sep 25, 2021

  • Added CHANGES.md entries
  • Added doc in README.md
  • Incorporated review comments

@nedtwigg
Copy link
Member

nedtwigg commented Sep 26, 2021

Please merge the latest origin/main into this PR. That should fix CI, at which point I can merge and release.

@tisoft
Copy link
ContributorAuthor

tisoft commented Sep 27, 2021

@nedtwigg rebased against main and fixed one copyright date. The test failure seems unrelated to me.

nedtwigg
nedtwigg reviewed Sep 27, 2021
View reviewed changes
@nedtwigg
Copy link
Member

nedtwigg commented Sep 27, 2021

Agree re: test faillure. I would merge if there wasn't low-hanging fruit re: the absolute path.

@nedtwiggnedtwigg merged commit 12aac3c into diffplug:mainSep 27, 2021
@tisofttisoft deleted the generic_native_cmd branch September 27, 2021 05:55
@nedtwigg
Copy link
Member

nedtwigg commented Sep 27, 2021

Published in plugin-maven 2.14.0.

@carhartlcarhartl mentioned this pull request Oct 9, 2021
Closed
carhartl added a commit to carhartl/spotless that referenced this pull request Oct 11, 2021
@carhartl
Make NativeCmd step available in Gradle plugin
21689ce
Maven support had been added in diffplug#949.
carhartl added a commit to carhartl/spotless that referenced this pull request Oct 11, 2021
@carhartl
Make NativeCmd step available in Gradle plugin
d2f34ae
Maven support had been added in diffplug#949.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nedtwiggnedtwiggnedtwigg requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tisoft@nedtwigg