Skip to content

Conversation

@ycexiao
Copy link
Contributor

What problem does this PR address?

Fix the failed tests as mentioned in #144

The newest version of pycifrw in conda-forge is 4.4.6, and in PyPI is 5.0.1. Some StarError is changed to YappsSyntaxError in the newer version of pycifrw and can not be caught by the parser in diffpy.structure. This is why tests failed in diffpy.structure=3.3.1rc0.

What should the reviewer(s) do?

Please check if catching the YappsSyntaxError as StructureFormatError is what we want.

@ycexiaoycexiao marked this pull request as ready for review July 23, 2025 23:18
@ycexiao
Copy link
ContributorAuthor

@bobleesj, it's ready for review.

@codecov
Copy link

codecovbot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.93%. Comparing base (9379e80) to head (b910f87).
Report is 3 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #146 +/- ## ======================================= Coverage 98.93% 98.93% ======================================= Files 13 13 Lines 1878 1878 ======================================= Hits 1858 1858 Misses 20 20 
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillinge
Copy link
Contributor

ah, its all resolved! Great work @ycexiao !!!! Please ignore all my other comments, this was done very well!

@sbillingesbillinge merged commit 6243638 into diffpy:mainJul 23, 2025
5 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ycexiao@sbillinge