deprecate: Add deprecation warning for diffpy.Structure#149
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #149 +/- ## ======================================= Coverage 98.93% 98.93% ======================================= Files 13 13 Lines 1878 1878 ======================================= Hits 1858 1858 Misses 20 20 🚀 New features to boost your workflow:
|
src/diffpy/structure/__init__.py Outdated
| import warnings | ||
| warnings.warn( | ||
| "Module 'diffpy.Structure' is deprecated. Use 'diffpy.structure' instead.", |
Contributor
There was a problem hiding this comment.
Is deprecated and will be removed in version 3.8. Use 'diffpy.structure' instead
ContributorAuthor
cadenmyers13 commented Nov 24, 2025
@sbillinge ready for review |
sbillinge merged commit 730a91e into diffpy:main 5 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See screenshot for deprecation warning. Had to do a custom one here for this specific deprecation