Refactor test-on-xtype test function #231
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Warning! No news item is found for this PR. If this is a user-facing change/feature/fix, |
ContributorAuthor
bobleesj commented Dec 14, 2024
@sbillinge Ready for review - probably better to review this #228 first.. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #231 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 8 8 Lines 357 362 +5 ========================================= + Hits 357 362 +5
|
sbillinge merged commit 3918433 into diffpy:main 3 of 4 checks passed
Uh oh!
There was an error while loading. Please reload this page.
59 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#229 - Refactor test_on_xtype() using @pytest.mark.parametrize and conftest.py