scikit:recut diffpy.utils using latest scikit-package.#369
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #369 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 9 9 Lines 520 520 ========================================= Hits 520 520 🚀 New features to boost your workflow:
|
Contributor
sbillinge left a comment
sbillinge left a comment There was a problem hiding this comment.
please see linline comments.
pyproject.toml Outdated
| namespaces = false # to disable scanning PEP 420 namespaces (true by default) | ||
| [project.scripts] | ||
| diffpy-utils = "diffpy.utils.app:main" |
Contributor
There was a problem hiding this comment.
I think this is wrong, it should have an underscore. As well as fixing here, this is presumably still a bug in scikit-package if you used the latest version.
ContributorAuthor
There was a problem hiding this comment.
Oh yes, we should also create an issue in scikit-package that the symbol before app should be an underscore
sbillinge merged commit 64ad577 into diffpy:main 7 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Contributor
sbillinge commented Dec 18, 2025
thanks @stevenhua0320. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sbillinge ready to review, most of the changes are reformatting of the documentation