fix: Remove API for calculating mu from packing fraction#370
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cadenmyers13 changed the title 
ContributorAuthor
cadenmyers13 commented Dec 21, 2025
@sbillinge ready for review |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #370 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 9 9 Lines 520 516 -4 ========================================= - Hits 520 516 -4
🚀 New features to boost your workflow:
|
sbillinge merged commit aab1765 into diffpy:main 7 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Contributor
sbillinge commented Dec 29, 2025
nice! |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes#339
I dont believe a test is needed since this is basically a wrapper for for
material_muinxraydb.