2.0.0: Client Secret Hasher Migration vs. Swapped Application Models

[josephabrahams]

Describe the bug

The forward migration introduced in #1093 to hash all previously saved client secrets runs on apps that use a custom application model and produces the following error:

AttributeError: Manager isn't available; 'oauth2_provider.Application' has been swapped for 'oauth.Application'

To Reproduce

Define a custom application model in settings.py:

OAUTH2_PROVIDER_APPLICATION_MODEL = "oauth.Application"

Migrate the database:

$ python manage.py migrate

Expected behavior

Migrations run when using a swappable application model without throwing an error.

Version 2.0

• I have tested with the latest published release and it's still a problem.
• I have tested with the master branch and it's still a problem.

[josephabrahams]

Potential fix to only run the migration when not using a custom application model in josephabrahams@a123285.

[n2ygk]

@josephabrahams Thanks for this report. Swappable models are the hardest part with this stuff!

Please submit your proposed fix as a PR where we can discuss.

Thanks.

[n2ygk]

I've been staring at this and I'm thinking the change should simply be:

from oauth2_provider import settings

# ...

 Application = apps.get_model(settings.APPLICATION_MODEL)

Furthermore all the migrations may need to be fixed for swappable models. See #634 where all hope is lost ;-(