Skip to content

Conversation

@ZuSe
Copy link
Contributor

@ZuSeZuSe commented Sep 15, 2021

Compare with https://datatracker.ietf.org/doc/html/rfc7662

Fixes #

Description of the Change

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

auvipy
auvipy previously requested changes Sep 21, 2021
Copy link
Contributor

@auvipyauvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to update the tests as well

@ZuSeZuSe changed the title Not existing tokens should return 200 as well withing introspectionNot existing tokens should return 200 within introspection (not 403)Sep 25, 2021
Copy link
Contributor

@n2ygkn2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. It looks right but needs the tests fixed. Also, you indicated that CHANGELOG was updated, AUTHORS, etc. but I don't see where you've done that.

The tests looks pretty easy to fix:

 E AssertionError: 200 != 401 

Please let me know if you can get to this soon as I'm targeting this for the next minor release.

@n2ygkn2ygk added this to the 1.7.0 milestone Dec 22, 2021
@n2ygk
Copy link
Contributor

n2ygk commented Jan 1, 2022

I've updated the checklist to indicate correct status of this PR.

@n2ygkn2ygk dismissed auvipy’s stale reviewJanuary 1, 2022 17:34

I made the requested changes.

@codecov
Copy link

codecovbot commented Jan 1, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.67%. Comparing base (c42423c) to head (19423dc).
Report is 217 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #1012 +/- ## ======================================= Coverage 96.67% 96.67% ======================================= Files 31 31 Lines 1775 1775 ======================================= Hits 1716 1716 Misses 59 59 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n2ygkn2ygk merged commit e657d7b into django-oauth:masterJan 1, 2022
@ZuSeZuSe deleted the fix/introspection branch January 4, 2022 12:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ZuSe@n2ygk@auvipy