Skip to content

Conversation

@CarlSchwan
Copy link
Contributor

@CarlSchwanCarlSchwan commented Feb 27, 2022

Description of the Change

inport os.environ is incorrect since environ is not a module, instead we just need to do import os and use os.environ

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added (not needed, no new code)
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS (not sure if this is needed, that change is not copyrightable because it's too trivial)

Copy link
Contributor

@n2ygkn2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Copy link
Contributor

@n2ygkn2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CarlSchwan Please do add yourself to AUTHORS anyway. It's not about copyright but about credit for contributing.

@codecov
Copy link

codecovbot commented Mar 18, 2022

Codecov Report

Merging #1121 (280a824) into master (5531cb9) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1121 +/- ## ======================================= Coverage 96.62% 96.62% ======================================= Files 32 32 Lines 1806 1806 ======================================= Hits 1745 1745 Misses 61 61 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5531cb9...280a824. Read the comment docs.

@n2ygk
Copy link
Contributor

@CarlSchwan Please do add yourself to AUTHORS anyway. It's not about copyright but about credit for contributing.

Never mind. I did it.

@CarlSchwan
Copy link
ContributorAuthor

@CarlSchwan Please do add yourself to AUTHORS anyway. It's not about copyright but about credit for contributing.

Never mind. I did it.

Thanks!

@n2ygkn2ygk merged commit e761ebc into django-oauth:masterMar 18, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@CarlSchwan@n2ygk