Revert 1070 (Celery tasks.py)#1126
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…lery and conflicts with Huey.
Codecov Report
@@ Coverage Diff @@## master #1126 +/- ## ========================================== + Coverage 96.59% 96.86% +0.26% ========================================== Files 32 31 -1 Lines 1794 1789 -5 ========================================== Hits 1733 1733 + Misses 61 56 -5 Continue to review full report at Codecov.
|
Andrew-Chen-Wang approved these changes Mar 19, 2022
Contributor
Andrew-Chen-Wang left a comment
Andrew-Chen-Wang left a comment There was a problem hiding this comment.
recommendation: Add the function to a utils file and describe how to use it in the docs and docstring.
ContributorAuthor
n2ygk commented Mar 19, 2022
I've added a new Tutorial in #1128 that addresses this. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#1114
Fixes#1123
Description of the Change
#1070 was apparently not tested (and was not supplied with a test case). It could never have worked and also has since been flagged as conflicting with Huey's auto-discovery which also uses
tasks.py.A future PR might come which will document how to configure a Celery
clear_tokenstask.Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS