Skip to content

add spanish translations#1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JordiNeil merged 3 commits into from
May 30, 2022
Merged

add spanish translations #1166

JordiNeil merged 3 commits into from
May 30, 2022

Conversation

@JordiNeil
Copy link
Contributor

@JordiNeilJordiNeil commented May 30, 2022

Description of the Change

Add spanish translations.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@JordiNeilJordiNeil requested a review from a teamMay 30, 2022 03:01
@codecov
Copy link

codecovbot commented May 30, 2022•
edited
Loading

Codecov Report

Merging #1166 (4cedac5) into master (f76b0f5) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1166 +/- ## ======================================= Coverage 96.87% 96.87% ======================================= Files 31 31 Lines 1794 1794 ======================================= Hits 1738 1738 Misses 56 56

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f76b0f5...4cedac5. Read the comment docs.

Andrew-Chen-Wang
Andrew-Chen-Wang suggested changes May 30, 2022
View reviewed changes
Copy link
Contributor

@Andrew-Chen-WangAndrew-Chen-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

sorry if I'm nitpicking too much; just remembering my days in spanish class

Andrew-Chen-Wang
Andrew-Chen-Wang approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@Andrew-Chen-WangAndrew-Chen-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome. thanks for educating me 😅

@JordiNeilJordiNeil merged commit c22c179 into masterMay 30, 2022
@n2ygkn2ygk deleted the add-spanish-translations branch June 3, 2022 16:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Andrew-Chen-WangAndrew-Chen-WangAndrew-Chen-Wang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JordiNeil@Andrew-Chen-Wang