Skip to content

Conversation

@porowns
Copy link
Contributor

@porownsporowns commented Jul 1, 2022

Fixes#1178

Description of the Change

The getting started tutorial excludes the 'code_verifier' when fetching the access token. This is causing confusion, example #1178

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

Copy link
Contributor

@n2ygkn2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Please add your name to AUTHORS along with a short description of the improvement to CHANGELOG (or I can do that).

@codecov
Copy link

codecovbot commented Jul 1, 2022

Codecov Report

Merging #1182 (5effcef) into master (8041939) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1182 +/- ## ======================================= Coverage 96.85% 96.85% ======================================= Files 31 31 Lines 1813 1813 ======================================= Hits 1756 1756 Misses 57 57 

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@porownsporowns requested a review from n2ygkAugust 4, 2022 17:09
@n2ygkn2ygk merged commit 08bfa04 into django-oauth:masterAug 6, 2022
@n2ygkn2ygk added this to the 2.2.0 milestone Oct 18, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

can't make tutorial "getting started" , django-oauth-toolkit 2.0.0

2 participants

@porowns@n2ygk